fix: better errors text for WalletConnect #2308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
If the error from the blockchain is not "translated" to human reable text, currently the error text is visible in the logs only which is inconvenient.
Changed this to a more informative, e.g.:
It's way more helpful.
Types of changes
Steps to reproduce
Generate a new type of error and see the toast. Or comment out handling of double delegation and delegate to the same address twice to see the error.
Screenshots
Add the screenshots of how the app used to look like and how it looks now
Before:
Now:
Error log:
Before:
Now:
Checklist