-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make @umami/state package platform agnostic #2329
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
OKendigelyan
changed the title
Make state package platform agnostic
Make @umami/state package platform agnostic
Jan 20, 2025
OKendigelyan
force-pushed
the
make-state-package-platform-agnostic
branch
from
January 20, 2025 19:35
24c50df
to
8c96a3e
Compare
OKendigelyan
force-pushed
the
make-state-package-platform-agnostic
branch
from
January 20, 2025 19:40
8c96a3e
to
d3c72f8
Compare
OKendigelyan
force-pushed
the
make-state-package-platform-agnostic
branch
3 times, most recently
from
January 21, 2025 12:14
ed7421d
to
54dfc39
Compare
asiia-trilitech
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @OKendigelyan - the code looks great 🔥 🔥 🔥
OKendigelyan
force-pushed
the
make-state-package-platform-agnostic
branch
from
January 21, 2025 15:27
7bcfdbf
to
e9e8d45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
@chakra-ui
dependencies from@umami/state
and makes it platform agnostic for web and mobile use.