Update web messages #2333
Open
Update web messages #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
asiia-trilitech
force-pushed
the
fix-web-bugs
branch
from
111d7b0 to
14ac5a5
Compare
asiia-trilitech
changed the title
asiia-trilitech
force-pushed
the
fix-web-bugs
branch
from
14ac5a5 to
1ee9a60
Compare
asiia-trilitech
force-pushed
the
fix-web-bugs
branch
from
9a05e0e to
26bfc91
Compare
asiia-trilitech
force-pushed
the
fix-web-bugs
branch
from
26bfc91 to
abf5ab8
Compare
asiia-trilitech
force-pushed
the
fix-web-bugs
branch
from
abf5ab8 to
74acec9
Compare
asiia-trilitech
force-pushed
the
fix-web-bugs
branch
from
74acec9 to
45cb166
Compare
OKendigelyan
approved these changes
Jan 30, 2025
| @@ -54,7 +54,7 @@ describe("<AccountsList />", () => { | |||
| await act(() => user.click(removeSocial)); | |||
|
|
|||
| expect(screen.getByTestId("description")).toHaveTextContent( | |||
| "Are you sure you want to remove all of your Social Accounts?" | |||
| "Are you sure you want to remove all of your Social accounts?" | |||
There was a problem hiding this comment.
why S is capital in social ?
There was a problem hiding this comment.
commented on copy doc for this
| expect(screen.getByRole("dialog")).toHaveTextContent("Add Contact"); | ||
| expect(screen.getByTestId("confirmation-button")).toHaveTextContent("Add Contact"); | ||
| expect(screen.getByRole("dialog")).toHaveTextContent("Add to address book"); | ||
| expect(screen.getByTestId("confirmation-button")).toHaveTextContent("Add to address book"); |
There was a problem hiding this comment.
I dont see this suggestion in the copy doc. Also Add contact seems better.
| @@ -112,7 +112,7 @@ export const EditContactMenu: FC<{ | |||
| type="submit" | |||
| variant="primary" | |||
| > | |||
| {isEdit ? "Update" : "Add Contact"} | |||
| {isEdit ? "Update" : "Add to address book"} | |||
There was a problem hiding this comment.
Commented on copy doc for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Copy Requirements Doc
Task link
Types of changes
Checklist