Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOBILE][UMA-1118] Theme tokens #2362

Open
wants to merge 45 commits into
base: main
Choose a base branch
from

Conversation

mariotrilitech
Copy link
Collaborator

Proposed changes

[Task link](UMA-1118)
[Task link](UMA-1119)
[Task link](UMA-1120)

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

This PR updates the Tamagui theme configuration to include theme tokens, define light and dark themes, and integrate theme switching based on system preferences.

Changes Implemented
1️⃣ Define Theme Tokens
Added primary, secondary, background, and text colors as theme tokens.
Defined border radius, spacing, and typography tokens.
Included custom tokens for additional flexibility.
2️⃣ Create Light & Dark Themes
Defined separate light and dark theme objects.
Ensured color contrasts meet accessibility standards.
3️⃣ Integrate Theme Switching
Applied useColorScheme from React Native to detect and apply the system theme.

Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-embed-iframe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:36am
umami-embed-iframe-ghostnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:36am
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:36am
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:36am

@mariotrilitech mariotrilitech changed the base branch from main to feat/navigation February 3, 2025 08:42
Copy link
Contributor

@OKendigelyan OKendigelyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small comment 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename the folder to styles to make it clear that it's dedicated to style, including themes, colours, useful hooks and so on

Base automatically changed from feat/navigation to main February 3, 2025 14:52
Copy link
Contributor

@OKendigelyan OKendigelyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the Feat: prefix from the PR name and specify the project [Mobile]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants