-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOBILE][UMA-1118] Theme tokens #2362
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with small comment 👍
apps/mobile/theme/colours.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rename the folder to styles
to make it clear that it's dedicated to style, including themes, colours, useful hooks and so on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the Feat: prefix from the PR name and specify the project [Mobile]
Proposed changes
[Task link](UMA-1118)
[Task link](UMA-1119)
[Task link](UMA-1120)
Types of changes
This PR updates the Tamagui theme configuration to include theme tokens, define light and dark themes, and integrate theme switching based on system preferences.
Changes Implemented
1️⃣ Define Theme Tokens
Added primary, secondary, background, and text colors as theme tokens.
Defined border radius, spacing, and typography tokens.
Included custom tokens for additional flexibility.
2️⃣ Create Light & Dark Themes
Defined separate light and dark theme objects.
Ensured color contrasts meet accessibility standards.
3️⃣ Integrate Theme Switching
Applied useColorScheme from React Native to detect and apply the system theme.