Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web][UMA-1105] WC and Beacon hang on unanswered request #2375

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dianasavvatina
Copy link
Contributor

Proposed changes

UMA-1105 Beacon and WalletConnect bug: wallet stops reacting on requests after dApp connected with open request modal

WalletConnect is queueing the incoming requests. If the request modal gets hidden (e.g. by Beacon request or connection proposal modal), then WalletConnect will wait forever.

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Steps to reproduce

Steps for WalletConnect on Umami web:

  1. connect https://taquito-test-dapp.pages.dev/
  2. confirm on wallet side
  3. disconnect from wallet side (to be able to reconnect via a deep link alter on)
  4. connect https://wc2.kukai.tech/?network=ghostnet
  5. run some operation from Kukai and see the open modal on wallet
  6. connect https://taquito-test-dapp.pages.dev/, select existing pairing to activate deep link
  7. now wallet opens session proposal modal. confirm
  8. kukai's modal disappeared
  9. run operation from Taquito - wallet doesn't react
  10. run operation from Kukai - wallet doesn't react

Scenario 2 (even more probable):

  1. connect https://taquito-test-dapp.pages.dev/ with Beacon
  2. connect https://wc2.kukai.tech/?network=ghostnet with WalletConnect
  3. send request from Kukai. See the modal open
  4. send request from Taquito. See the new modal open. Confirm
  5. WalletConnect request from Kukai is now stuck

Workaround:

  • reload wallet page
  • now modal from Taquito appears - confirm
  • now modal from Kukai appears 2 times - confirm

Steps for Beacon on Umami desktop:

  1. connect https://www.fxhash.xyz
  2. go https://www.fxhash.xyz/marketplace/generative/0
  3. make collection offer for 0.1 tez --> the modal is open on desktop
  4. connect ManUtd dApp --> closes request modal and allows to connect
  5. try to make a new collection offer from fxhash --> no reaction on desktop

Screenshots

Add the screenshots of how the app used to look like and how it looks now

Before Now

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

@dianasavvatina dianasavvatina self-assigned this Feb 7, 2025
Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-embed-iframe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 2:37pm
umami-embed-iframe-ghostnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 2:37pm
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 2:37pm
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 2:37pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant