Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game loop cleanup #246

Merged
merged 9 commits into from
Nov 12, 2024
Merged

Game loop cleanup #246

merged 9 commits into from
Nov 12, 2024

Conversation

adam4813
Copy link
Member

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: Patch coverage is 9.31677% with 146 lines in your changes missing coverage. Please review.

Project coverage is 10.88%. Comparing base (27bf5da) to head (6d0d63a).

Files with missing lines Patch % Lines
client/game.cpp 0.00% 35 Missing ⚠️
common/controllers/fps-controller.cpp 0.00% 31 Missing ⚠️
client/graphics/render-list.hpp 3.70% 26 Missing ⚠️
common/lua-system.cpp 22.58% 24 Missing ⚠️
common/physics-system.cpp 0.00% 11 Missing ⚠️
client/manipulators/placement.cpp 0.00% 9 Missing ⚠️
client/game.hpp 0.00% 5 Missing ⚠️
common/components/collision-body.hpp 0.00% 1 Missing ⚠️
common/controllers/fps-controller.hpp 75.00% 1 Missing ⚠️
common/multiton.hpp 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
+ Coverage   10.86%   10.88%   +0.01%     
==========================================
  Files         110      110              
  Lines       13348    13335      -13     
==========================================
+ Hits         1450     1451       +1     
+ Misses      11898    11884      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam4813 adam4813 merged commit 1b0690f into master Nov 12, 2024
12 of 13 checks passed
@adam4813 adam4813 deleted the game-loop-cleanup branch November 12, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant