Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix movement issues and improve event handling #254

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

adam4813
Copy link
Member

@adam4813 adam4813 commented Dec 15, 2024

Description

Address jerky movement from server to client, prevent window closing on focus loss, and implement an EventList for better event batching with corresponding tests. Clean up unused variable warnings.

Motivation and Context

At present, when moving, it appears to do a double move or delayed move. This was due to a hack "fix" in the physics system update. The fix was no longer needed

How Has This Been Tested?

Running locally for movement validation

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Fix window closing when losing focus by disabling focus callback

Extract EventList and add test for batching of events

Fix some variable not used warning
@adam4813 adam4813 marked this pull request as ready for review December 15, 2024 19:19
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 11.09%. Comparing base (1b0690f) to head (5cdcc81).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
client/resources/vorbis-stream.cpp 0.00% 1 Missing ⚠️
server/save-game.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   10.88%   11.09%   +0.21%     
==========================================
  Files         110      111       +1     
  Lines       13335    13397      +62     
==========================================
+ Hits         1451     1486      +35     
- Misses      11884    11911      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam4813 adam4813 merged commit c0fe066 into main Dec 16, 2024
13 checks passed
@adam4813 adam4813 deleted the fix-movement branch December 16, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant