Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add renderable to connected users and fix mouse look #255

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Conversation

adam4813
Copy link
Member

@adam4813 adam4813 commented Dec 16, 2024

Description

Update user entity to attach renderable for client side use only

Remove unused appveyor config

Fix mouse look

Motivation and Context

How Has This Been Tested?

Running multiple instances of the client when connecting to the same server shows updated movement. Initial state isn't updated to reflect the current server's state, so still work needed for the physics state sync.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@c0fe066). Learn more about missing BASE report.

Files with missing lines Patch % Lines
client/client-game-state-queue.cpp 0.00% 2 Missing ⚠️
common/controllers/fps-controller.cpp 0.00% 1 Missing ⚠️
server/client-connection.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage        ?   11.12%           
=======================================
  Files           ?      111           
  Lines           ?    13399           
  Branches        ?        0           
=======================================
  Hits            ?     1490           
  Misses          ?    11909           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam4813 adam4813 changed the title Re-add renderable to connected users Re-add renderable to connected users and fix mouse look Dec 16, 2024
@adam4813 adam4813 merged commit ce84d8f into main Dec 22, 2024
13 checks passed
@adam4813 adam4813 deleted the render-users branch December 22, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant