01 - Add request logging mechanism #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Randgalt
changed the title
vagaerg
reviewed
Jun 25, 2024
trino-s3-proxy/src/main/java/io/trino/s3/proxy/server/rest/StreamingResponseHandler.java
Outdated
Show resolved
Hide resolved
trino-s3-proxy/src/main/java/io/trino/s3/proxy/server/rest/TrinoS3ProxyClient.java
Outdated
Show resolved
Hide resolved
trino-s3-proxy/src/main/java/io/trino/s3/proxy/server/signing/InternalSigningController.java
Show resolved
Hide resolved
vagaerg
reviewed
Jun 25, 2024
trino-s3-proxy/src/main/java/io/trino/s3/proxy/server/rest/RequestLogger.java
Outdated
Show resolved
Hide resolved
Randgalt
force-pushed
the
jordanz/request-logging
branch
from
4dfd008
to
c0fa6ea
Compare
|
@vagaerg all comments addressed |
Randgalt
force-pushed
the
jordanz/request-logging
branch
4 times, most recently
from
8946fef
to
9efb701
Compare
Randgalt
changed the title
Randgalt
force-pushed
the
jordanz/request-logging
branch
2 times, most recently
from
c9c85a4
to
3efbe80
Compare
Randgalt
force-pushed
the
jordanz/request-logging
branch
2 times, most recently
from
bd79898
to
3fbc13c
Compare
mosiac1
reviewed
Jun 28, 2024
trino-s3-proxy/src/main/java/io/trino/s3/proxy/server/rest/RequestBuilder.java
Show resolved
Hide resolved
trino-s3-proxy/src/main/java/io/trino/s3/proxy/server/rest/RequestLoggerController.java
Outdated
Show resolved
Hide resolved
trino-s3-proxy/src/main/java/io/trino/s3/proxy/server/rest/RequestLoggerController.java
Outdated
Show resolved
Hide resolved
trino-s3-proxy/src/main/java/io/trino/s3/proxy/server/rest/RequestLoggerController.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Override | ||
| public Void handleException(Request request, Exception exception) | ||
| throws RuntimeException | ||
| { | ||
| throw propagate(request, exception); | ||
| requestLoggingSession.logException(exception); | ||
| requestLoggingSession.close(); |
There was a problem hiding this comment.
I feel like we shouldn't be calling close() here, but I'm also unsure where it should be called
There was a problem hiding this comment.
Please see #83 which improves management of this.
trino-s3-proxy/src/main/java/io/trino/s3/proxy/server/signing/InternalSigningController.java
Outdated
Show resolved
Hide resolved
trino-s3-proxy/src/main/java/io/trino/s3/proxy/server/rest/RequestLoggingSession.java
Show resolved
Hide resolved
trino-s3-proxy/src/main/java/io/trino/s3/proxy/server/rest/RequestLoggerController.java
Show resolved
Hide resolved
Randgalt
force-pushed
the
jordanz/request-logging
branch
from
3fbc13c
to
a890eb7
Compare
TODO - add complete telemetry system Adds controller that logs requests and allows for eventual admin API that can return recent request info Relates to #25
Randgalt
force-pushed
the
jordanz/request-logging
branch
from
a890eb7
to
e0c4fa6
Compare
mosiac1
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO - add complete telemetry system
Adds controller that logs requests and allows for eventual admin
API that can return recent request info
Relates to #25