Skip to content

Commit

Permalink
Don't use an external action for generating a changelog
Browse files Browse the repository at this point in the history
The generated changelog was not used, because it was not located in the
chart directory. Releases should only include files commited in the
repository, so avoid generatic a changelog file and instead use the
GitHub API to generate notes automatically in the GitHub release.
  • Loading branch information
nineinchnick committed May 30, 2024
1 parent 3932c8f commit 9195298
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 39 deletions.
25 changes: 0 additions & 25 deletions .github/changelog-config.json

This file was deleted.

15 changes: 1 addition & 14 deletions .github/workflows/ci-cd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -98,27 +98,14 @@ jobs:
if: github.event_name != 'pull_request'
steps:
- uses: actions/checkout@v4
with:
# history is required to generate changelog
fetch-depth: 0
- name: Configure Git
run: |
git config user.name "$GITHUB_ACTOR"
git config user.email "[email protected]"
- name: Build release changelog
id: github_release
uses: mikepenz/release-changelog-builder-action@v4
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
configuration: '.github/changelog-config.json'
outputFile: ${{ runner.temp }}/CHANGELOG.md
- name: Inspect changelog
run: cat ${{ runner.temp }}/CHANGELOG.md
- name: Release charts
uses: helm/[email protected]
env:
CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
CR_RELEASE_NOTES_FILE: ${{ runner.temp }}/CHANGELOG.md
CR_GENERATE_RELEASE_NOTES: true
# If we didn't bump the chart version then we can skip the release
CR_SKIP_EXISTING: true

0 comments on commit 9195298

Please sign in to comment.