Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding on autoscaling templating #101

Closed
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ You can then run `helm search repo trino` to see the charts.
Then you can install chart using:

```console
helm install my-trino trino/trino --version 0.13.0
praktiskt marked this conversation as resolved.
Show resolved Hide resolved
helm install my-trino trino/trino --version 0.13.1
```

## Documentation
Expand Down
2 changes: 1 addition & 1 deletion charts/trino/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.13.0
version: 0.13.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
4 changes: 2 additions & 2 deletions charts/trino/templates/autoscaler.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- if .Values.server.autoscaling.enabled -}}
apiVersion: autoscaling/v1
apiVersion: {{ .Values.server.autoscaling.apiVersion }}
kind: HorizontalPodAutoscaler
metadata:
name: {{ template "trino.worker" . }}
Expand All @@ -14,5 +14,5 @@ spec:
apiVersion: apps/v1
kind: Deployment
name: {{ template "trino.worker" . }}
targetCPUUtilizationPercentage: {{ .Values.server.autoscaling.targetCPUUtilizationPercentage }}
{{- .Values.server.autoscaling.extraSpec | nindent 2 }}
{{- end }}
7 changes: 6 additions & 1 deletion charts/trino/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,12 @@ server:
autoscaling:
enabled: false
maxReplicas: 5
targetCPUUtilizationPercentage: 50
apiVersion: autoscaling/v1
# extraSpec contains a templated HPA specification. Depending on the apiVersion,
# you may be able to configure more advanced behavior and metrics.
# See https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/
extraSpec: |-
targetCPUUtilizationPercentage: 50

accessControl: {}
# type: configmap
Expand Down