Add support for running sidecars container #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
reviewed
Oct 11, 2023
losipiuk
reviewed
Oct 11, 2023
losipiuk
reviewed
Oct 11, 2023
radek-kondziolka
force-pushed
the
rk/add_support_for_sidecars
branch
from
86eb630 to
75045d7
Compare
radek-kondziolka
force-pushed
the
rk/add_support_for_sidecars
branch
from
75045d7 to
70151c9
Compare
mosabua
requested changes
Oct 11, 2023
charts/trino/values.yaml
Outdated
| securityContext: | ||
| runAsUser: 1000 | ||
| runAsGroup: 1000 | ||
|
|
||
| shareProcessNamespace: | ||
| # coordinator: false |
There was a problem hiding this comment.
Should that not be true? So that when comments are removed the sidecar actually works..
There was a problem hiding this comment.
No, it is optional.
radek-kondziolka
force-pushed
the
rk/add_support_for_sidecars
branch
3 times, most recently
from
1bd29d2 to
c33625a
Compare
radek-kondziolka
force-pushed
the
rk/add_support_for_sidecars
branch
from
c33625a to
e789800
Compare
losipiuk
approved these changes
Oct 20, 2023
|
cc: @nineinchnick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.