Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hpa behavior #120

Merged
merged 1 commit into from
Jan 15, 2024
Merged

add hpa behavior #120

merged 1 commit into from
Jan 15, 2024

Conversation

fl0-m
Copy link
Member

@fl0-m fl0-m commented Jan 8, 2024

add hpa behavior & bump autoscaling api to v2

Copy link

cla-bot bot commented Jan 8, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@fl0-m
Copy link
Member Author

fl0-m commented Jan 9, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jan 9, 2024
Copy link

cla-bot bot commented Jan 9, 2024

The cla-bot has been summoned, and re-checked this pull request!

@fl0-m
Copy link
Member Author

fl0-m commented Jan 10, 2024

@losipiuk @sopel39 PTAL 🙏

@sopel39 sopel39 requested a review from hashhar January 10, 2024 10:29
@fl0-m
Copy link
Member Author

fl0-m commented Jan 15, 2024

@losipiuk Any visibility on when a new Trino chart version will be released ?

@losipiuk losipiuk merged commit c991681 into trinodb:main Jan 15, 2024
6 checks passed
@losipiuk
Copy link
Member

@losipiuk Any visibility on when a new Trino chart version will be released ?

@mosabua is it just about bumping version and CI will do the job?

@fl0-m
Copy link
Member Author

fl0-m commented Jan 15, 2024

@losipiuk To me we just need to bump chart version, Github action on main branch takes care of the rest
could you please also merge resource groups PR
before bumping ?

@losipiuk
Copy link
Member

@losipiuk To me we just need to bump chart version, Github action on main branch takes care of the rest could you please also merge resource groups PR before bumping ?

Sorry - did not notice - can you bump to 0.17?

@justrelax19
Copy link

@losipiuk Now with the help of above PR, can we use the hpa to autoscale the worker nodes based on our custom metrics ie does it support writing prometheus metrics or something to define the custom metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants