Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support service annotations #134

Merged
merged 1 commit into from
May 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/trino/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ Fast distributed SQL query engine for big data analytics that helps you explore
A list of the Linux kernel capabilities that are dropped from every container. Valid values are listed at https://man7.org/linux/man-pages/man7/capabilities.7.html Ensure to remove the "CAP_" prefix which the kernel attaches to the names of permissions.
* `shareProcessNamespace.coordinator` - bool, default: `false`
* `shareProcessNamespace.worker` - bool, default: `false`
* `service.annotations` - object, default: `{}`
* `service.type` - string, default: `"ClusterIP"`
* `service.port` - int, default: `8080`
* `auth` - object, default: `{}`
Expand Down
2 changes: 2 additions & 0 deletions charts/trino/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ metadata:
{{- if .Values.commonLabels }}
{{- tpl (toYaml .Values.commonLabels) . | nindent 4 }}
{{- end }}
annotations:
{{- toYaml .Values.service.annotations | nindent 4 }}
spec:
type: {{ .Values.service.type }}
ports:
Expand Down
1 change: 1 addition & 0 deletions charts/trino/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,7 @@ shareProcessNamespace:
worker: false

service:
annotations: {}
type: ClusterIP
port: 8080

Expand Down
4 changes: 4 additions & 0 deletions test-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ additionalConfigProperties:
- http-server.authentication.allow-insecure-over-http=true
- http-server.process-forwarded=true

service:
annotations:
custom/name: value

auth:
# created using htpasswd -B -C 10 password.db admin
# every password is admin123
Expand Down