-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional prometheus pod monitor #135
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Isa.Inalcik.
|
2 similar comments
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Isa.Inalcik.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Isa.Inalcik.
|
@cla-bot check |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Isa.Inalcik.
|
The cla-bot has been summoned, and re-checked this pull request! |
@cla-bot check |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Isa.Inalcik.
|
The cla-bot has been summoned, and re-checked this pull request! |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Isa.Inalcik.
|
57dfbcb
to
f31a5c0
Compare
…kubernetes-podmonitor
# Requires the prometheus-operator to be installed in the cluster | ||
# Requires jmx_exporter to be installed in the cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how we should test this. Should there be a separate job in https://github.com/trinodb/charts/blob/main/.github/workflows/ci-cd.yaml, that would install these requirements? If we won't be testing this, I don't think it should be included in the chart.
Added Optional Prometheus Pod Monitor Support
Hey everyone,
I've added a new feature to Trino Helm charts that lets you easily monitor your Trino pods with Prometheus. This is totally optional, so you can turn it on or off as you like. Here's a quick rundown of what's new:
monitoring.enabled
. Handy if you're trying out different setups.monitoring.path
andmonitoring.port
, you tell Prometheus where to find the metrics it needs to scrape. This means you can set it up exactly how you like it.monitoring.interval
andmonitoring.scrapeTimeout
to control how often Prometheus looks for new metrics and how long it waits. This gives you control over the load and responsiveness of your monitoring setup.monitoring.honorLabels
andmonitoring.honorTimestamps
let you control if Prometheus should use the labels and timestamps from your metrics as they are. This can help with sorting and understanding your data.monitoring.additionalPodTargetLabels
to add extra labels from your pods. This is great for when you need to filter your metrics or dig into the details.I hope this helps make monitoring with Prometheus. Looking forward to your feedback and suggestions!