Use standard labels #172
Merged
Use standard labels #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
force-pushed
the
debug-test-failures
branch
3 times, most recently
from
c910a07 to
29647fe
Compare
nineinchnick
force-pushed
the
debug-test-failures
branch
3 times, most recently
from
bf80de6 to
2c77ce6
Compare
Use standard Helm labels, following https://helm.sh/docs/chart_best_practices/labels/#standard-labels. Use labels on all resources, so the chart can be uninstall correctly.
nineinchnick
force-pushed
the
debug-test-failures
branch
4 times, most recently
from
f818cf2 to
6523345
Compare
Because `ct install` calls `helm test` without `--logs`, always pass `--skip-clean-up`, and get the logs and cleanup manually after a failure.
nineinchnick
force-pushed
the
debug-test-failures
branch
from
4d425f1 to
1571914
Compare
nineinchnick
force-pushed
the
debug-test-failures
branch
from
a47a08c to
1571914
Compare
wendigo
approved these changes
May 30, 2024
This was referenced May 30, 2024
nineinchnick
added a commit
to nineinchnick/trino
that referenced
this pull request
Oct 8, 2024
Update the instructions to match changes done in the Trino Helm chart over the last few months. Related chart pull requests: * trinodb/charts#172 * trinodb/charts#228
mosabua
pushed a commit
to trinodb/trino
that referenced
this pull request
Oct 8, 2024
Update the instructions to match changes done in the Trino Helm chart over the last few months. Related chart pull requests: * trinodb/charts#172 * trinodb/charts#228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use standard Helm labels, following https://helm.sh/docs/chart_best_practices/labels/#standard-labels. Use labels on all resources, so the chart can be uninstalled correctly.
Additionally, print logs after failed installs. Because
ct installcallshelm testwithout--logs, always pass--skip-clean-up, and get the logs and cleanup manually after a failure.