Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ability to define the nodePort in the trino service #204

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

dantonbertuol
Copy link
Contributor

Hello.

This PR is to be able to customize the NodePort in the Trino service.

I adjusted it due to the issue #203.

Copy link

cla-bot bot commented Aug 13, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

charts/trino/templates/service.yaml Outdated Show resolved Hide resolved
charts/trino/values.yaml Outdated Show resolved Hide resolved
Copy link

cla-bot bot commented Aug 14, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@nineinchnick
Copy link
Member

Please update the README - see the CI run failure: https://github.com/trinodb/charts/actions/runs/10386833434/job/28759113778?pr=204

Also, squash the commits into a single one. I can merge this as soon as the CLA clears out.

Copy link

cla-bot bot commented Aug 14, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@dantonbertuol dantonbertuol force-pushed the feature/service-node-port branch from 2b28463 to 651fdf8 Compare August 14, 2024 11:59
Copy link

cla-bot bot commented Aug 14, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@dantonbertuol dantonbertuol force-pushed the feature/service-node-port branch from 651fdf8 to d9d4153 Compare August 14, 2024 12:01
Copy link

cla-bot bot commented Aug 14, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@dantonbertuol
Copy link
Contributor Author

Please update the README - see the CI run failure: https://github.com/trinodb/charts/actions/runs/10386833434/job/28759113778?pr=204

Also, squash the commits into a single one. I can merge this as soon as the CLA clears out.

I changed it as per your request.

@dantonbertuol dantonbertuol force-pushed the feature/service-node-port branch from d9d4153 to 4d33075 Compare August 14, 2024 12:50
Copy link

cla-bot bot commented Aug 14, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@dantonbertuol
Copy link
Contributor Author

@nineinchnick This error is a little strange, don't you think?
https://github.com/trinodb/charts/actions/runs/10387904546/job/28762488147?pr=204

@nineinchnick
Copy link
Member

I copied those two lines into a text editor and only then noticed that there are two spaces missing at the end of the line. This is needed by markdown to correctly wrap the following lines into the bullet point.

I should have mentioned this earlier - you shouldn't edit the file manually, but use helm-docs to generate it automatically. There's a pre-commit hook that you could install to have this done automatically when you commit any other changes.

@dantonbertuol dantonbertuol force-pushed the feature/service-node-port branch from 4d33075 to 5a44fef Compare August 14, 2024 13:25
Copy link

cla-bot bot commented Aug 14, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@dantonbertuol
Copy link
Contributor Author

I copied those two lines into a text editor and only then noticed that there are two spaces missing at the end of the line. This is needed by markdown to correctly wrap the following lines into the bullet point.

I should have mentioned this earlier - you shouldn't edit the file manually, but use helm-docs to generate it automatically. There's a pre-commit hook that you could install to have this done automatically when you commit any other changes.

Ah, thanks for the information, I adjusted the readme again.

@dantonbertuol
Copy link
Contributor Author

Hi @nineinchnick!

My CLA has been completed.

@nineinchnick
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Aug 14, 2024
Copy link

cla-bot bot commented Aug 14, 2024

The cla-bot has been summoned, and re-checked this pull request!

@nineinchnick nineinchnick merged commit c073dfa into trinodb:main Aug 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants