Optional catalogs and related configmap #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdaberdaku
force-pushed
the
feature/optional-catalogs
branch
from
220645d to
6a93457
Compare
|
@nineinchnick last one for today :)! |
nineinchnick
approved these changes
Sep 26, 2024
sdaberdaku
force-pushed
the
feature/optional-catalogs
branch
from
6a93457 to
009b00e
Compare
|
Hi @nineinchnick , I implemented the suggested changes. |
nineinchnick
approved these changes
Sep 26, 2024
sdaberdaku
force-pushed
the
feature/optional-catalogs
branch
from
009b00e to
67c54f7
Compare
nineinchnick
approved these changes
Sep 26, 2024
nineinchnick
added a commit
to nineinchnick/trino
that referenced
this pull request
Oct 8, 2024
Update the instructions to match changes done in the Trino Helm chart over the last few months. Related chart pull requests: * trinodb/charts#172 * trinodb/charts#228
mosabua
pushed a commit
to trinodb/trino
that referenced
this pull request
Oct 8, 2024
Update the instructions to match changes done in the Trino Helm chart over the last few months. Related chart pull requests: * trinodb/charts#172 * trinodb/charts#228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the default
tpchandtpcdscatalogs from the related configmap into a unifiedcatalogsconfiguration where users will be able to remove them if neccessary.If no catalogs are provided, the related configmap will not be created/mounted.
This
additionalCatalogsproperty has now been deprecated in favor of the newly introducedcatalogs.Fixes: #210