Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .Values.server.config.http section from chart #233

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

romsharon98
Copy link
Contributor

closes: #229

Copy link

cla-bot bot commented Sep 29, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

1 similar comment
Copy link

cla-bot bot commented Sep 29, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@romsharon98
Copy link
Contributor Author

verified cla, can you run the test again please? @nineinchnick

@nineinchnick
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Oct 2, 2024
Copy link

cla-bot bot commented Oct 2, 2024

The cla-bot has been summoned, and re-checked this pull request!

@nineinchnick
Copy link
Member

Please squash both commits and write a good commit message, like "Remove unused property"

@romsharon98
Copy link
Contributor Author

Please squash both commits and write a good commit message, like "Remove unused property"

done.

@nineinchnick nineinchnick merged commit e86c971 into trinodb:main Oct 3, 2024
9 checks passed
@nineinchnick nineinchnick changed the title remove .Values.server.config.http section from chart Remove .Values.server.config.http section from chart Oct 3, 2024
@nineinchnick nineinchnick added the bug Something isn't working label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla-signed
Development

Successfully merging this pull request may close these issues.

.Values.server.config.http.port is never used
3 participants