Add support for Database resource group manager #252
Merged
+156
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yassan
force-pushed
the
add-resource-groups-db
branch
2 times, most recently
from
0f831fb to
b41f219
Compare
nineinchnick
reviewed
Nov 5, 2024
|
|
yassan
force-pushed
the
add-resource-groups-db
branch
from
ba18e1d to
0a1953e
Compare
|
@nineinchnick All issues have been addressed. Could you please review again? |
yassan
force-pushed
the
add-resource-groups-db
branch
2 times, most recently
from
df4f739 to
e5f8517
Compare
nineinchnick
force-pushed
the
add-resource-groups-db
branch
from
e17e892 to
2afeac7
Compare
nineinchnick
force-pushed
the
add-resource-groups-db
branch
from
2afeac7 to
63df119
Compare
nineinchnick
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the Trino Helm chart by adding support for the Database resource group manager. Previously, only file-based configurations using ConfigMap were supported.
Additionally, the implementation is closely modeled after the existing accessControl pattern in the chart, ensuring consistency in the configuration approach.
Limitations
In the process of implementing this feature, we considered deploying the MySQL container in the same namespace as Trino to streamline configuration. However, the MySQL service endpoint URL includes the namespace, making it challenging to set a dynamic reference. To maintain stability and avoid complex configurations, we fixed the MySQL namespace as mysql, ultimately deciding against further attempts at a flexible namespace solution for this PR.