Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service annotations support to Trino Gateway Chart #258

Merged

Conversation

yashsinghalso
Copy link
Contributor

  • Introduced functionality to allow specifying annotations for Trino Gateway services.
  • Ensures compatibility with Kubernetes custom annotations for enhanced service configurations.
  • Updated relevant templates and documentation to reflect the changes.

This feature enables users to add annotations for service monitoring, ingress, or other Kubernetes integrations.

Copy link

cla-bot bot commented Nov 20, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

charts/gateway/templates/_helpers.tpl Outdated Show resolved Hide resolved
charts/gateway/templates/_helpers.tpl Outdated Show resolved Hide resolved
Copy link

cla-bot bot commented Nov 20, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@nineinchnick
Copy link
Member

@cla-bot check

Copy link

cla-bot bot commented Nov 28, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Nov 28, 2024

The cla-bot has been summoned, and re-checked this pull request!

@nineinchnick nineinchnick added the enhancement New feature or request label Dec 4, 2024
@yashsinghalso
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Dec 5, 2024
Copy link

cla-bot bot commented Dec 5, 2024

The cla-bot has been summoned, and re-checked this pull request!

@nineinchnick nineinchnick changed the title Feat: Add service annotations support to Trino Gateway Chart Add service annotations support to Trino Gateway Chart Dec 5, 2024
Copy link
Member

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash commits and remove the feat: prefix

@yashsinghalso
Copy link
Contributor Author

Can you provide me the write access? The merging is blocked for me- due to failing merge requirements.

@nineinchnick
Copy link
Member

I'll merge this PR once you squash the commits locally and push it to this branch. It's more important to have a good commit message, that's why I'm asking you to address this. See the end of this section: https://trino.io/development/process#pull-request-and-commit-guidelines-

Resolved last comments

updated the trino gateway readme
@yashsinghalso yashsinghalso force-pushed the adding-annotations-for-service branch from 674bb86 to 24d0c69 Compare December 5, 2024 09:21
@nineinchnick nineinchnick merged commit 4471ee1 into trinodb:main Dec 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants