-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test framework for gateway #261
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmostly
force-pushed
the
will/gateway-tests
branch
from
November 22, 2024 02:56
99aa3df
to
289d3e3
Compare
@nineinchnick do you prefer a separate test script as done here or should I merge this into the existing |
willmostly
force-pushed
the
will/gateway-tests
branch
4 times, most recently
from
November 22, 2024 21:45
999694e
to
ff234bd
Compare
willmostly
force-pushed
the
will/gateway-tests
branch
from
December 3, 2024 01:16
ff234bd
to
8c00b72
Compare
@nineinchnick this is ready for another review |
willmostly
force-pushed
the
will/gateway-tests
branch
from
December 3, 2024 01:31
8c00b72
to
d1c4828
Compare
nineinchnick
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after adjusting CI job names.
willmostly
force-pushed
the
will/gateway-tests
branch
4 times, most recently
from
December 3, 2024 16:18
e6c169a
to
aced773
Compare
nineinchnick
added
the
ignore-for-release
This will NOT be mentioned in release notes
label
Dec 4, 2024
nineinchnick
approved these changes
Dec 4, 2024
Co-authored-by: Jan Waś <[email protected]>
willmostly
force-pushed
the
will/gateway-tests
branch
from
December 4, 2024 15:19
4c48d51
to
0415c7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test script for the gateway mimicking the form of the trino tests and call it in
ci-cd
. More comprehensive test logic will be added in follow up PRs