Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test framework for gateway #261

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

willmostly
Copy link
Contributor

Add a test script for the gateway mimicking the form of the trino tests and call it in ci-cd. More comprehensive test logic will be added in follow up PRs

@willmostly
Copy link
Contributor Author

@nineinchnick do you prefer a separate test script as done here or should I merge this into the existing test.sh?

gateway-tests/test.sh Outdated Show resolved Hide resolved
gateway-tests/test-values.yaml Outdated Show resolved Hide resolved
.github/workflows/ci-cd.yaml Show resolved Hide resolved
gateway-tests/test.sh Outdated Show resolved Hide resolved
@willmostly willmostly force-pushed the will/gateway-tests branch 4 times, most recently from 999694e to ff234bd Compare November 22, 2024 21:45
@cla-bot cla-bot bot added the cla-signed label Dec 3, 2024
@willmostly
Copy link
Contributor Author

@nineinchnick this is ready for another review

Copy link
Member

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adjusting CI job names.

.github/workflows/ci-cd.yaml Outdated Show resolved Hide resolved
.github/workflows/ci-cd.yaml Outdated Show resolved Hide resolved
@willmostly willmostly force-pushed the will/gateway-tests branch 4 times, most recently from e6c169a to aced773 Compare December 3, 2024 16:18
@nineinchnick nineinchnick added the ignore-for-release This will NOT be mentioned in release notes label Dec 4, 2024
.github/workflows/ci-cd.yaml Outdated Show resolved Hide resolved
@nineinchnick nineinchnick merged commit 5be2a66 into trinodb:main Dec 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed ignore-for-release This will NOT be mentioned in release notes
Development

Successfully merging this pull request may close these issues.

2 participants