Pass through service spec values

[willmostly]

Kubernetes supports several types of services. This change passes through arbitrary keys under service.spec, which allows specifying type-specific keys such as nodePort. The port and targetPort are autoconfigured to match the port specified in the gateway http-server configuration, and the selector is autoconfigured to match the deployment.

Suggested release note:

• Set custom service attributes. Breaking change: the service node no longer uses type and port as a subfields. Define the service.spec instead.

[nineinchnick]

I like adding these new test suites! Just a bunch of nitpicks remaining.

[nineinchnick]

We're not reading any properties from this spec key, so if this test passes without these settings, it means it's not a good test. Should it be using different port numbers?

[willmostly]

I outsmarted myself with this logic in charts/gateway/templates/test-nodeport.yaml:

        - |
          {{- if eq .Values.service.type "NodePort" }}
          [ "$(wget --no-check-certificate https://${NODE_IP}:{{ index .Values.service.ports 0 "nodePort"}}/entity/GATEWAY_BACKEND -O -)" = "[]" ] &&
          [ "$(wget http://${NODE_IP}:{{ index .Values.service.ports 1 "nodePort"}}/entity/GATEWAY_BACKEND -O -)" = "[]" ]
          {{- else }}
          echo non NodePort service type
          {{- end }}

the invalid key effectively disabled the test. I think this can be fixed by using serverConfig as the independent variable

[willmostly]

The values files using service.spec failed after the correction to connection-test.yaml to check if serverConfig.http-server.http[s].enabled = =true, so I think the test is now good

[nineinchnick]

Almost there, just two nitpicks about testing.

[nineinchnick]

The service name should be hardcoded here - it's ok, because it's a test. If we change anything in the chart and this test would start to fail, this verifies the test. Same for ports. What would happen if you'd set a service port different from http-server.https.port?

[nineinchnick]

Note that we don't verify if this node port is reachable. We could add an extra wget in the test-connection in a conditional block that'd only run if the service was of type NodePort.