Fix NaN values handling in the progressPercentage property #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
reviewed
Feb 24, 2025
mosabua
reviewed
Feb 24, 2025
mosabua
reviewed
Feb 24, 2025
mosabua
reviewed
Feb 24, 2025
| @@ -47,7 +47,6 @@ public bool scheduled | |||
| public long processedBytes { get; set; } | |||
| public long peakMemoryBytes { get; set; } | |||
| public long spilledBytes { get; set; } | |||
| public long progressPercentage { get; set; } | |||
There was a problem hiding this comment.
Separate commit .. and also why are you removing this?
There was a problem hiding this comment.
Since it's unused and there are other properties that are also missing here, I decided that the simplest fix is to remove it. However, I can also change its type to double, as defined here: QueryProgressStats.java#L34
There was a problem hiding this comment.
Hmm, I'm ok either way, do we know why it's unused in Java? Is this a Presto legacy? I'd keep it as it's optional until it's removed from the Java
stelmukhov
force-pushed
the
feature/nan-progress
branch
from
7f59008 to
0b09627
Compare
georgewfisher
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple fix for trino-csharp-client#12 since the
progressPercentageproperty is unused.Another option is to change the
progressPercentagetype fromlongtodouble,as it uses
OptionalDoublein Trino (QueryProgressStats.java#L34).Thanks