Add retry on 429 error code #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lshrinivas
reviewed
Mar 1, 2024
| lambda response: getattr(response, "status_code", None) | ||
| in (502, 503, 504), | ||
| in (429, 502, 503, 504), |
There was a problem hiding this comment.
Do we need to add any delays for the retry? Immediate retry will just make the problem worse (not sure if that's already built in)
electrum
previously requested changes
Mar 1, 2024
|
This behavior needs to be specified in https://trino.io/docs/current/develop/client-protocol.html There is a standard |
hovaesco
force-pushed
the
hovaesco/retry-429
branch
from
d18dae0
to
dfa6840
Compare
hashhar
reviewed
Jul 8, 2024
trino/client.py
Outdated
| @@ -887,7 +895,11 @@ def decorated(*args, **kwargs): | |||
| try: | |||
| result = func(*args, **kwargs) | |||
| if any(guard(result) for guard in conditions): | |||
| handle_retry.retry(func, args, kwargs, None, attempt) | |||
| if result.status_code == 429 and "Retry-After" in result.headers: | |||
| handle_retry_sleep = _RetryAfterSleep(result.headers.get("Retry-After")) | |||
There was a problem hiding this comment.
Add a method to convert header value to seconds. The header can be a point-in-time too. See https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Retry-After#syntax in which case this code will throw.
There was a problem hiding this comment.
I've added a method _parse_retry_after_header for parsing Retry-After header.
hovaesco
force-pushed
the
hovaesco/retry-429
branch
from
dfa6840
to
872a6f4
Compare
hovaesco
force-pushed
the
hovaesco/retry-429
branch
from
872a6f4
to
0e54f25
Compare
hashhar
approved these changes
Aug 2, 2024
hashhar
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add retry on 429 error code
Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: