Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve char type and comparison docs #20457

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Jan 24, 2024

Description

Follow up to https://trinodb.slack.com/archives/CP1MUNEUX/p1705983989648189

Additional context and related issues

None

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@mosabua mosabua requested a review from martint January 24, 2024 20:05
@cla-bot cla-bot bot added the cla-signed label Jan 24, 2024
@github-actions github-actions bot added the docs label Jan 24, 2024
@mosabua mosabua changed the title Clarify char comparisons Improve char type and comparison docs Mar 2, 2024
@mosabua
Copy link
Member Author

mosabua commented Mar 2, 2024

@martint I stripped down the char type docs and added an examples section in comparison page. And fixed up format and styling..

Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Mar 25, 2024
@mosabua
Copy link
Member Author

mosabua commented Mar 26, 2024

Waiting for final review from @martint

@github-actions github-actions bot removed the stale label Mar 27, 2024
@mosabua mosabua added the stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. label Apr 11, 2024
@mosabua
Copy link
Member Author

mosabua commented Jan 15, 2025

Maybe @kasiafi can chime in and help moving this forward? Please ...

@mosabua
Copy link
Member Author

mosabua commented Jan 20, 2025

Ping @kasiafi and @martint

@mosabua mosabua requested a review from kasiafi January 20, 2025 17:18
@mosabua
Copy link
Member Author

mosabua commented Jan 27, 2025

Thanks @martint

@mosabua mosabua merged commit e2ec103 into trinodb:master Jan 27, 2025
8 checks passed
@mosabua mosabua deleted the char-comparison branch January 27, 2025 18:34
@github-actions github-actions bot added this to the 469 milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed docs stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.
Development

Successfully merging this pull request may close these issues.

2 participants