Fix table function execution without partitioning #21378
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/exclude-columns-streaming
branch
from
3a50d3b to
cb2452b
Compare
tbaeg
reviewed
Apr 3, 2024
| passThroughSpecifications, | ||
| processEmptyInput)) | ||
| .flatMap(TableFunctionPartition::toOutputPages); | ||
| if (partitionChannels.isEmpty()) { |
There was a problem hiding this comment.
Do we want to to check if the List is empty as well? I tested locally on some custom table functions by cherry-picking this commit and ran into this case.
There was a problem hiding this comment.
my understanding is that empty list is legitimate, and requires global aggregation (one partition)
findepi
force-pushed
the
findepi/exclude-columns-streaming
branch
from
cb2452b to
2c28e2f
Compare
|
just rebased, no other changes |
Previously, when table function did not declare partitioning, it would be globally distributed, but on a worker node it would run single-threaded and first buffer all data in memory, like a one big WINDOW. After the change, the local execution processes input pages in a streaming fashion. This commit also fixes property derivations for a case where table function is partitioned on empty list of symbols (global grouping).
findepi
force-pushed
the
findepi/exclude-columns-streaming
branch
from
2c28e2f to
40ba52f
Compare
|
( rebased, no other changes ) |
|
draft -- this implementation has suboptimal lifecycle for |
kasiafi
approved these changes
May 17, 2024
|
Any traction on this? We have been running a fork with these changes and would love for it to be in trino proper. |
|
@mosabua I think we can close - I would be opening a new PR for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when table function did not declare partitioning, it would be globally distributed, but on a worker node it would run single-threaded and first buffer all data in memory, like a one big WINDOW. After the change, the local execution processes input pages in a streaming fashion.
This commit also fixes property derivations for a case where table function is partitioned on empty list of symbols (global grouping).
Fixes #20398