Add week to UnwrapDateTruncInComparison #21408
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
reviewed
Apr 5, 2024
| Arguments.of("year", "<=", "2024-12-31", "<=", "2024-12-31")); | ||
| } | ||
|
|
||
| @ParameterizedTest |
There was a problem hiding this comment.
Avoid using ParameterizedTest. See how other similar tests are structured
There was a problem hiding this comment.
Changed to helper + one test a line. PTAL
|
|
||
| @ParameterizedTest | ||
| @MethodSource("compareParams") | ||
| public void testDateCompareGreaterThanOrEquals(String unit, String compareOp, String target, String expectedOp, String limit) |
There was a problem hiding this comment.
Avoid abbreviations (e.g., expectedOp -> expectedOperator)
jinyangli34
force-pushed
the
jinyang-add_week_for_date_trunc_unwrap
branch
from
4bbbb07 to
edcb9fc
Compare
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
mosabua
added
the
stale-ignore
jinyangli34
force-pushed
the
jinyang-add_week_for_date_trunc_unwrap
branch
from
edcb9fc to
8165c64
Compare
|
@ebyhr independently we may want to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow date_trunc optimization for
weekunitAdd unit tests
Additional context and related issues
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: