Update Redis version requirement #21455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
commented
Apr 8, 2024
| @@ -18,7 +18,7 @@ string and hash types are supported. | |||
| Requirements for using the connector in a catalog to connect to a Redis data | |||
| source are: | |||
|
|
|||
| - Redis 2.8.0 or higher (Redis Cluster is not supported) | |||
| - Redis 5.0.0 or higher (Redis Cluster is not supported) | |||
There was a problem hiding this comment.
We could also do 5.0.14 or higher to be in sync with the testing
wendigo
approved these changes
Apr 8, 2024
|
Chatted with @electrum and we decided to go with 5.0.14 and be in sync with the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent PR upgraded testing.. adjusting docs .. but 5.0.0 (https://github.com/redis/redis/releases/tag/5.0.0) is still very old so maybe we should even go with 6.0.0 (https://github.com/redis/redis/releases/tag/6.0.0)
We could also use https://github.com/redis/redis/releases/tag/5.0.14 .. since that has a lot of security issues fixed and is a least a bit newer .. and also what we use in testing now.
Additional context and related issues
#21431 (comment)
Release notes
Not sure if we should say we are dropping support for Redis < 5.0.14 @colebow