-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade oracle test version #24505
base: master
Are you sure you want to change the base?
Upgrade oracle test version #24505
Conversation
95c9ddd
to
578a6c5
Compare
Oracle test failed:
|
578a6c5
to
1a90bd2
Compare
plugin/trino-oracle/src/test/java/io/trino/plugin/oracle/TestingOracleServer.java
Show resolved
Hide resolved
d4b697e
to
2051b06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % comment
4cdd6b5
to
db92378
Compare
|
db92378
to
3e91b15
Compare
Please run stress tests by removing unnecessary jobs and duplicating Oracle job in |
1088b34
to
fbfc083
Compare
|
8d0d4ec
to
65a9f1c
Compare
053d648
to
1a4cd8a
Compare
Could you rebase on master to resolve conflicts? |
1a4cd8a
to
3dab010
Compare
a596054
to
21e671c
Compare
This pull request has gone a while without any activity. Tagging for triage help: @mosabua |
@chenjian2664 I think you need to work with @ebyhr and @hashhar on next steps. From my perspective the CI changes need to be backed out and you need to do a rebase. Anything else? |
7543512
to
2d3f891
Compare
@ebyhr @hashhar , I’d like your suggestions on how to minimize the logs during testing. To clarify, since I run multiple Oracle tests, only one test is expected to succeed, while the others encounter Currently, I’m using a Linux pipe to filter logs and only capture ERROR messages. This approach works and can report the correct error message for debug. But, I’m wondering if there’s a more natural or elegant way to handle this. |
run: | | ||
if [ "${{ matrix.modules }}" == "plugin/trino-oracle" ]; then | ||
echo "Running tests for oracle..." | ||
$MAVEN test ${MAVEN_TEST} -pl ${{ matrix.modules }} ${{ matrix.profile != '' && format('-P {0}', matrix.profile) || '' }} 2>&1 | grep "ERROR" || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, Here is the logic to filter only ERROR logs
72482f2
to
fa40ac8
Compare
This pull request has gone a while without any activity. Tagging for triage help: @mosabua |
If 18 is the highest version we test with .. we have to update the requirements section in the docs to 18 .. |
@mosabua agreed |
(rebased & solved conflict) |
|
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: