Cleanup test schema in connector tests #24823
Conversation
anusudarsan
force-pushed
the
anu/cleanup-test-schema-bq
branch
4 times, most recently
from
d82cf20 to
43a2da7
Compare
| try { | ||
| assertUpdate("CREATE SCHEMA " + schemaName); |
There was a problem hiding this comment.
I'm not sure why we need this change. Could you share the motivation?
There was a problem hiding this comment.
there were left over schema in bigquery from this test (not sure what exact CI failures) because of unproper cleanup. Over time this (and other tests being fixed here) caused a lot of schema left behind causing read timeout in BQ intermittently while getting schema
There was a problem hiding this comment.
It's a real issue, not specific to tests. We should suppress a timeout failure then the schema is created remotely like #13242. Could you file an issue to track this?
...rino-bigquery/src/test/java/io/trino/plugin/bigquery/BaseBigQueryCaseInsensitiveMapping.java
Outdated
Show resolved
Hide resolved
|
/test-with-secrets sha=43a2da76743abe38a71c20e704167006c5ca1d96 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/13020639959 |
anusudarsan
force-pushed
the
anu/cleanup-test-schema-bq
branch
from
43a2da7 to
7ec29af
Compare
|
I rebased on latest master. Please retrigger the CI with secrets. The failures looked unrelated |
|
@anusudarsan Could you confirm my review comments? |
anusudarsan
force-pushed
the
anu/cleanup-test-schema-bq
branch
2 times, most recently
from
fd3eed0 to
61a3000
Compare
done |
| try { | ||
| assertUpdate("CREATE SCHEMA " + schemaName); |
There was a problem hiding this comment.
It's a real issue, not specific to tests. We should suppress a timeout failure then the schema is created remotely like #13242. Could you file an issue to track this?
|
/test-with-secrets sha=61a3000047f33b92c498b51d03678e2267d6f8a6 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/13021759543 |
|
@anusudarsan Could you confirm CI failure? https://github.com/trinodb/trino/actions/runs/13021759543/job/36323735412 |
anusudarsan
force-pushed
the
anu/cleanup-test-schema-bq
branch
from
61a3000 to
f5945f8
Compare
|
/test-with-secrets sha=f5945f8aeb01f6143a69aa80ea0b6ab51e32946b |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/13041977312 |
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.