Support non-lower case variables in functions #24829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
approved these changes
Jan 28, 2025
martint
reviewed
Jan 28, 2025
| return name.getValue(); | ||
| // stop-gap: lowercasing for now to match what is happening during analysis; | ||
| // otherwise we do not support non-lowercase variables in functions. | ||
| return name.getValue().toLowerCase(ENGLISH); |
There was a problem hiding this comment.
Add a link to #17 so we can find the places that need to be fixed when we work on that issue.
wendigo
approved these changes
Jan 29, 2025
losipiuk
force-pushed
the
lukaszos/support-non-lower-case-variables-in-functions-492fc6
branch
from
9318bc3 to
d1b2674
Compare
|
Update RN entry .. this is only for SQL UDFs.. |
|
Not sure what docs we'd add. This is just regular identifier resolution rules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #24460
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: