Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query history to the Preview Web UI #24875

Closed
wants to merge 1 commit into from

Conversation

koszti
Copy link
Member

@koszti koszti commented Feb 1, 2025

Description

Add Query History with search to the preview UI. Partially addressing #22697

NOTE: The layout of the metric cards at the top is currently broken, which could lead to layout issues if the values begin to change. This may become more pronounced when running queries, particularly when testing the query history and filter functions. Please note that this layout issue is outside the scope of the current PR and will be resolved separately by another PR.

Additional context and related issues

Retains the same functionality as the existing web UI, enhanced with the updated layout, design, and user experience.

Screenshots

image

image

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## Section
* Add query history to the Preview Web UI. ({issue}`24875`)

@cla-bot cla-bot bot added the cla-signed label Feb 1, 2025
@github-actions github-actions bot added the ui Web UI label Feb 1, 2025
@koszti koszti changed the title Add query history to the Preview Web UI [WiP] Add query history to the Preview Web UI Feb 2, 2025
@koszti koszti force-pushed the preview-ui-query-history branch from 8210567 to 368e99e Compare February 3, 2025 23:52
@koszti koszti changed the title [WiP] Add query history to the Preview Web UI Add query history to the Preview Web UI Feb 4, 2025
@koszti koszti force-pushed the preview-ui-query-history branch 3 times, most recently from 00c52fd to 631920e Compare February 4, 2025 08:22
@wendigo
Copy link
Contributor

wendigo commented Feb 4, 2025

Screenshot 2025-02-04 at 13 13 10

These panes don't have the same height

@wendigo
Copy link
Contributor

wendigo commented Feb 4, 2025

I've built this branch but I can only see:

Screenshot 2025-02-04 at 13 16 31

@wendigo
Copy link
Contributor

wendigo commented Feb 4, 2025

Query text should go up (rather than being in a middle). Or we could stretch the box to be the same height as the details pane on the left:

Screenshot 2025-02-04 at 13 26 41

@wendigo
Copy link
Contributor

wendigo commented Feb 4, 2025

This dotted border is looking odd, let's make it solid one:
Screenshot 2025-02-04 at 13 28 07

@wendigo
Copy link
Contributor

wendigo commented Feb 4, 2025

I'd make these icons smaller:

Screenshot 2025-02-04 at 13 28 44

@wendigo
Copy link
Contributor

wendigo commented Feb 4, 2025

Can we save the state of the filters in the browser? So that when I go back and forth between the dashboard and other panes I'll have filters set?

@koszti
Copy link
Member Author

koszti commented Feb 4, 2025

Screenshot 2025-02-04 at 13 13 10 These panes don't have the same height

yes, that’s mentioned in the PR description, these cards are broken but not strongly related to this PR and wanted to fix separately. Do you want to make it as part if this PR?

@wendigo
Copy link
Contributor

wendigo commented Feb 4, 2025

@koszti either is fine (if in this PR - let's make it a separate commit)

@koszti koszti force-pushed the preview-ui-query-history branch 3 times, most recently from 960fe27 to 5928692 Compare February 9, 2025 09:31
@wendigo
Copy link
Contributor

wendigo commented Feb 9, 2025

Couple of nits:

Can we make the bottom border in line with the hightlight box?

Screenshot 2025-02-09 at 10 37 40

I've changed some of the icons, but can we make them smaller and add some right margin to them:

Screenshot 2025-02-09 at 11 07 02

icons are:

import AvTimerIcon from '@mui/icons-material/AvTimer';
import BadgeIcon from '@mui/icons-material/Badge'
import BrokenImageIcon from '@mui/icons-material/BrokenImage';
import CheckCircleIcon from '@mui/icons-material/CheckCircle';
import DevicesIcon from '@mui/icons-material/Devices'
import DownloadingIcon from '@mui/icons-material/Downloading'
import FunctionsIcon from '@mui/icons-material/Functions';
import GraphicEq from '@mui/icons-material/GraphicEq'
import GroupsIcon from '@mui/icons-material/Groups'
import HighlightOff from '@mui/icons-material/HighlightOff'
import HistoryToggleOffIcon from '@mui/icons-material/HistoryToggleOff';
import Memory from '@mui/icons-material/Memory'
import NotStartedIcon from '@mui/icons-material/NotStarted';
import PlayCircleIcon from '@mui/icons-material/PlayCircle';
import QueryBuilderIcon from '@mui/icons-material/QueryBuilder';

Can we make query box stand out less? Bring colors a couple of tones down (more grayish)?

a11yDark looks nicer to me:
Screenshot 2025-02-09 at 11 20 50

@koszti koszti force-pushed the preview-ui-query-history branch 2 times, most recently from 2532841 to 1f36494 Compare February 10, 2025 10:04
@github-actions github-actions bot added release-notes docs jdbc Relates to Trino JDBC driver hudi Hudi connector iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector labels Feb 10, 2025
@koszti koszti added cla-signed and removed clickhouse ClickHouse connector druid Druid connector duckdb DuckDB connector elasticsearch Elasticsearch connector exasol Exasol connector faker Faker connector google-sheets Google Sheets connector ignite Ignite connector kafka Kafka connector loki Loki connector mariadb MariaDB connector memory Memory connector mysql MySQL connector opensearch OpenSearch connector oracle Oracle connector pinot Pinot connector postgresql PostgreSQL connector prometheus Prometheus connector redis Redis connector redshift Redshift connector singlestore SingleStore connector sqlserver SQLServer connector vertica Vertica connector kudu phoenix5 jdbc Relates to Trino JDBC driver labels Feb 10, 2025
@koszti
Copy link
Member Author

koszti commented Feb 10, 2025

@wendigo I addressed all change requests but I messed up this PR with some incorrect rebase and merge. Instead of trying to make the git history and diff clean, I opened another and cleaned PR at #24972. Can we continue over there?

@koszti koszti closed this Feb 10, 2025
@koszti koszti deleted the preview-ui-query-history branch February 20, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants