Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct exchange.compression-codec documentation #24899

Conversation

losipiuk
Copy link
Member

@losipiuk losipiuk commented Feb 4, 2025

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Feb 4, 2025
@losipiuk losipiuk requested review from wendigo and mosabua February 4, 2025 12:53
@github-actions github-actions bot added the docs label Feb 4, 2025
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good .. but was that changed? Also .. is there a reason why we dont use compression .. should we document that its good practice to switch compression on?

@wendigo
Copy link
Contributor

wendigo commented Feb 4, 2025

@mosabua no, documentation was wrong from the beginning

@mosabua
Copy link
Member

mosabua commented Feb 4, 2025

Lets just merge it then.

@mosabua mosabua merged commit 69b9449 into trinodb:master Feb 4, 2025
8 checks passed
@github-actions github-actions bot added this to the 470 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants