Add support create table with primary key in mysql

[hqbhoho]

Description

Add MysqlTableProperties and support create table with primary key in mysql.

Release notes

## MySQL
* Add support for creating tables with `primary_key` table property. 

[hqbhoho]

I found In Ignite or phoenix will keep primary key information in table properties rather than column properties. So which way is better?

[ebyhr]

Please fix CI failures.

[hqbhoho]

Please fix CI failures.

it's done!

[Praveen2112]

How about for the datasources/tables which doesn't support primayKey/autoincrement ? Instead of implementing it directly for BaseJDBC module - Can we add them for each datasource and unify them once we are sure on how each datasource behave ?

[hqbhoho]

Thanks for the feedback! In the java.sql package, DatabaseMetaData defines methods such as getPrimaryKeys and getColumns. The getColumns method returns information about whether a column is IS_AUTOINCREMENT. I believe this is a common JDBC specification. Therefore, I think it can be placed in the BaseJDBC module.Different data sources may have different implementations. If there is a problem, it is likely to be due to the implementation of the data source.

[chenjian2664]

I think you can add primary key first, for the autoIncrement it's seems specify to the connectors

[hqbhoho]

I think you can add primary key first, for the autoIncrement it's seems specify to the connectors

Thanks for the feedback! As mentioned in the document, the attributes of a column should include data type, default value, isNullable, isAutoIncrement, comment and so on. In the future, I also want to add default value configurations.

In the current implementation, If user create table with primary key and autoincrement and the datasources/tables which doesn't support primayKey/autoincrement, these pieces of information will not be included in the generated table creation statement.Therefore, I believe this will not result in any erroneous impact, it's just that these configuration will not take effect if datasources/tables which doesn't support.

@Praveen2112 @chenjian2664 It's better to implement custom JdbcColumnHandle and ColumnPropertiesProvider for different JDBC connectors even if their contents are the same? If that's the case, I will open a new PR to implement only mysql first.

[chenjian2664]

If user create table with primary key and autoincrement and the datasources/tables which doesn't support primayKey/autoincrement, these pieces of information will not be included in the generated table creation statement

Would it be better for this behavior to throw exceptions in such cases?

Since you're modifying the base JDBC module, it's needs to consider carefully as different connectors may have varying driver behaviors. You might also need to update the base connector tests for all connectors, implementing this at the base level could ensure consistency(no matter the connector support or not support), while adding it to a specific connector might keep things cleaner.

I also suggest prioritizing primary key support first, as we've already involved this feature in some connectors, though not support create it directly.

[ebyhr]

Would it be better for this behavior to throw exceptions in such cases?

We should definitely throw an exception if the data source doesn’t support primary keys.

[hqbhoho]

Would it be better for this behavior to throw exceptions in such cases?

We should definitely throw an exception if the data source doesn’t support primary keys.

@chenjian2664 @ebyhr @Praveen2112 So It's better to add primary key in base JDBC module first and check all data source, throw an exception if the data source doesn’t support primary keys in this PR. And then open a new PR to support autoincrement, default value and other attribute in a specified data source such as mysql. Is this implementation feasible?
Or we can first implement these features (such as primary keys, auto-increment, default values, etc.) in MySQL, and then gradually extend them to other data sources.

Please give me suggestions，thanks!

[chenjian2664]

I think we could add primary key in Mysql first

[hqbhoho]

I think we could add primary key in Mysql first

thanks, I am re-implementing it and only support MySQL table creation with primary key.

[hqbhoho]

@chenjian2664 @Praveen2112 @ebyhr could you help review when you have a time? thanks

[chenjian2664]

Looks good % comments, good job.

cc @ebyhr

[hqbhoho]

@chenjian2664 Thank you for the assistance you've provided!
@ebyhr @Praveen2112 Could you confirm if this can be merged? Thanks!

[github-actions]

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

[ebyhr]

Please add a test that primary_key table property has an uppercase column name.

[hqbhoho]

Please add a test that primary_key table property has an uppercase column name.

Done