Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ZSTD encoding for exchange compression #24974

Closed
wants to merge 1 commit into from

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Feb 10, 2025

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Feb 10, 2025
@starburstdata-automation
Copy link

starburstdata-automation commented Feb 10, 2025

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_part.

Building Trino finished with status: success
Benchmark finished with status: failure
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: Found regressions for:<br/>(presto/tpch, q03, prestoQuery-totalCpuTime, over by 53.2%)<br/>(presto/tpch, q09, prestoQuery-totalCpuTime, over by 37.8%)<br/>(presto/tpcds, q50, prestoQuery-totalCpuTime, over by 31.5%)
Benchmark Comparison to the closest run from Master: Report

@starburstdata-automation
Copy link

starburstdata-automation commented Feb 10, 2025

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_unpart.

Building Trino finished with status: success
Benchmark finished with status: failure
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: Found regressions for:<br/>(presto/tpch, q03, prestoQuery-totalCpuTime, over by 16.2%)<br/>(presto/tpch, q09, prestoQuery-totalCpuTime, over by 36.4%)<br/>(presto/tpcds, q50, prestoQuery-totalCpuTime, over by 32.6%)
Benchmark Comparison to the closest run from Master: Report

@starburstdata-automation
Copy link

starburstdata-automation commented Feb 10, 2025

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_part.

Building Trino finished with status: success
Benchmark finished with status: failure
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: Found regressions for:<br/>(presto/tpch, q03, prestoQuery-totalCpuTime, over by 54.4%)<br/>(presto/tpch, q09, prestoQuery-totalCpuTime, over by 38.2%)<br/>(presto/tpcds, q50, prestoQuery-totalCpuTime, over by 34.2%)<br/>(presto/tpcds, q78, prestoQuery-totalCpuTime, over by 11.8%)
Benchmark Comparison to the closest run from Master: Report

@starburstdata-automation
Copy link

starburstdata-automation commented Feb 10, 2025

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_unpart.

Building Trino finished with status: success
Benchmark finished with status: failure
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: Found regressions for:<br/>(presto/tpch, q03, prestoQuery-totalCpuTime, over by 16.9%)<br/>(presto/tpch, q09, prestoQuery-totalCpuTime, over by 36.6%)<br/>(presto/tpcds, q50, prestoQuery-totalCpuTime, over by 32.6%)
Benchmark Comparison to the closest run from Master: Report

@wendigo wendigo force-pushed the serafin/enable-exchange-compression branch 2 times, most recently from 876272b to dd22e40 Compare February 10, 2025 15:54
@github-actions github-actions bot added the jdbc Relates to Trino JDBC driver label Feb 10, 2025
@wendigo wendigo force-pushed the serafin/enable-exchange-compression branch from dd22e40 to 5067571 Compare February 10, 2025 16:07
@github-actions github-actions bot added the hive Hive connector label Feb 10, 2025
@wendigo wendigo marked this pull request as draft February 10, 2025 16:11
@wendigo wendigo closed this Feb 10, 2025
@wendigo wendigo deleted the serafin/enable-exchange-compression branch February 10, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed hive Hive connector jdbc Relates to Trino JDBC driver
Development

Successfully merging this pull request may close these issues.

2 participants