Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Snappy encoding for exchange compression #24976

Closed
wants to merge 2 commits into from
Closed

Enable Snappy encoding for exchange compression #24976

wants to merge 2 commits into from

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Feb 10, 2025

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Feb 10, 2025
@github-actions github-actions bot added the jdbc Relates to Trino JDBC driver label Feb 10, 2025
@starburstdata-automation
Copy link

starburstdata-automation commented Feb 10, 2025 •
edited
Loading

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_part.

Building Trino finished with status: success
Benchmark finished with status: failure
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: Found regressions for:<br/>(presto/tpch, q03, prestoQuery-totalCpuTime, over by 30.0%)<br/>(presto/tpch, q09, prestoQuery-totalCpuTime, over by 13.0%)<br/>(presto/tpcds, q50, prestoQuery-totalCpuTime, over by 17.7%)
Benchmark Comparison to the closest run from Master: Report

@starburstdata-automation
Copy link

starburstdata-automation commented Feb 10, 2025 •
edited
Loading

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_unpart.

Building Trino finished with status: success
Benchmark finished with status: failure
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: Found regressions for:<br/>(presto/tpch, q09, prestoQuery-totalCpuTime, over by 15.1%)<br/>(presto/tpcds, q50, prestoQuery-totalCpuTime, over by 19.9%)
Benchmark Comparison to the closest run from Master: Report

@wendigo wendigo force-pushed the serafin/snappy-exchange-compression branch 3 times, most recently from 67f1a27 to 153bb8c Compare February 10, 2025 15:36
@wendigo wendigo changed the title Snappy exchange compression Enable Snappy encoding for exchange compression Feb 10, 2025
@wendigo wendigo force-pushed the serafin/snappy-exchange-compression branch from 153bb8c to 9b6e03c Compare February 10, 2025 16:07
@github-actions github-actions bot added the hive Hive connector label Feb 10, 2025
martint
martint requested changes Feb 10, 2025
View reviewed changes
Copy link
Member

@martint martint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have LZ4. We don’t need snappy

@wendigo
Copy link
Contributor Author

wendigo commented Feb 10, 2025

@martint this is for benchmark purposes. Disregard

@wendigo wendigo marked this pull request as draft February 10, 2025 16:11
@wendigo wendigo closed this Feb 10, 2025
@wendigo wendigo deleted the serafin/snappy-exchange-compression branch February 10, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martint martint martint requested changes

@raunaqmorarka raunaqmorarka Awaiting requested review from raunaqmorarka

Assignees
No one assigned
Labels
cla-signed hive Hive connector jdbc Relates to Trino JDBC driver
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wendigo @starburstdata-automation @martint