Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 405 extend Biosample Browser sep__biological_sample field to Project #406

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

dsenalik
Copy link
Collaborator

@dsenalik dsenalik commented Mar 1, 2022

This pull request shows the changes used on carrotomics.org to display NCBI biosamples on project pages.

It extends the sep__biological_sample (Biosample Browser) to also be usable on Project content type.

A working example on the CarrotOmics site:
https://carrotomics.org/bio_data/290817

I've been using these changes for close to a year, it's about time I submitted them!

@spficklin
Copy link
Member

Hey @dsenalik . Thanks for the update. I'm going to merge it. It looks good.

However, after looking at your PR I noticed a major problem with this field (not your fault). It's not following proper coding standards. I'll merge this so that you can use it on your site, but the field does need to be corrected. I created an issue about it and what needs to be done to fix it: #407.

@spficklin spficklin merged commit 98b202f into tripal:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants