Skip to content

Commit

Permalink
Build: Remove 'check' task when building game-installers (#12129)
Browse files Browse the repository at this point in the history
We already run './gradlew check' against merges to master
and any PR. Thus, the check as pre-requisite for building
game installers is redundant.

This update opens up a possibility that a 'check' could
fail after merging to master & we still build game
installer artifacts. In this case we will still get
notification that the main branch build has failed.
Such a situation should be rare enough that the simplicity
in not having to configure our branch tests twice, is
worth the trade-off.
  • Loading branch information
DanVanAtta authored Nov 26, 2023
1 parent 607f8ac commit 494e92b
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/upload-game-installers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ jobs:
with:
distribution: temurin
java-version: 11
- name: Run Build Checks
run: ./game-app/run/check
- name: Build Installers
run: ./game-app/run/package
env:
Expand Down

0 comments on commit 494e92b

Please sign in to comment.