Automatically start a DB on docker via gradle #12124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanVanAtta
force-pushed
the
docker-from-gradle
branch
from
9edd7ea to
d0a6c27
Compare
DanVanAtta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary & Additional Notes
Instead of having to run a shell script to start database before running
./gradlew check, with this update the database will start as a dependency as the check task.This is done by adding a
docker-compose.ymlfile which starts database. We can run runcomposeUpfrom gradle as a dependency to running DB tests, or as a dependency for running the lobby (which requires a DB)../gradlew testWithDatabasenow automatically starts a database, as does running a lobby. There is no longer a need to run the 'start-database.sh' script for gradle tasks to work.