Remove wiremock tests where we start a server during test #12152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update removes the HTTP client tests for things like the lobby, maps & game-support server. In these cases, as part of testing, we launch these servers via docker-compose and will then use our HTTP client to do testing. The independent wiremock test of these same HTTP clients is redundant. On the other hand, wiremock is still useful when we don't control the server, or can't invoke the server all the time (EG: githubs web-api). We still keep wiremock for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update removes the HTTP client tests for things like the lobby, maps & game-support server. In these cases, as part of testing, we launch these servers via docker-compose and will then use our HTTP client to do testing. The independent wiremock test of these same HTTP clients is redundant.
On the other hand, wiremock is still useful when we don't control the server, or can't invoke the server all the time (EG: githubs web-api). We still keep wiremock for this.
Notes to Reviewer