I18n v2 (@NonNls + Locals for toLowerCase/toUpperCase) #12840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frigoref
commented
Aug 17, 2024
frigoref
commented
- add @NonNls to respective Strings
- Locals for toLowerCase() or toUpperCase() calls
(.*String .+ *= "\w+\.[A-Za-z]+[A-Za-z\.]*)
(.*String .* = .*\+.*")
AbstractConditionsAttachment.java AbstractImageFactory.java AutoPlacementFinder.java ClipPlayer.java CliProperties.java CommentPanel.java DownloadFile.java FileNameUtils.java FlagIconImageFactory.java GameParser.java GameRunner.java InGameLobbyWatcher.java MapData.java NodeBbForumPoster.java NotificationMessages.java ObjectiveProperties.java PoliticsText.java ProductionRepairPanel.java ProductionTabsProperties.java TooltipProperties.java UnitIconProperties.java UnitImageFactory.java
…g-pattern (.*static final String .* = ")
(toUpperCase\()\)
… calls (?<!NonNls) (p.* static final String)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.