Merge pull request #198 from tyler92/division-by-zero

Prevent potential division by zero
tristanpenman · Oct 20, 2024 · 7fd212f · 7fd212f
2 parents fc9ddf1 + 63c56dd
commit 7fd212f
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/include/valijson/constraints/concrete_constraints.hpp b/include/valijson/constraints/concrete_constraints.hpp
@@ -19,6 +19,7 @@
 #include <set>
 #include <string>
 #include <vector>
+#include <cmath>
 
 #include <valijson/constraints/basic_constraint.hpp>
 #include <valijson/internal/custom_allocator.hpp>
@@ -784,6 +785,11 @@ class MultipleOfDoubleConstraint:
 
     void setDivisor(double newValue)
     {
+        if (!std::isfinite(newValue) || newValue <= 0.0) {
+            throwRuntimeError(
+                "Divisor for 'multipleOf' or 'divisibleBy' must be positive");
+        }
+
         m_value = newValue;
     }
 
@@ -813,6 +819,11 @@ class MultipleOfIntConstraint:
 
     void setDivisor(int64_t newValue)
     {
+        if (newValue <= 0) {
+            throwRuntimeError(
+                "Divisor for 'multipleOf' or 'divisibleBy' must be positive");
+        }
+
         m_value = newValue;
     }