Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add response statistics #6869

Merged
merged 15 commits into from
Feb 17, 2024
Merged

Add response statistics #6869

merged 15 commits into from
Feb 17, 2024

Conversation

kthui
Copy link
Contributor

@kthui kthui commented Feb 7, 2024

@kthui kthui marked this pull request as ready for review February 7, 2024 18:58
Copy link
Contributor

@oandreeva-nv oandreeva-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides readme, this pr lgtm. In case of urgency ping me and I'll approve, we can follow up with clarifications to readme later.

oandreeva-nv
oandreeva-nv previously approved these changes Feb 14, 2024
Copy link
Contributor

@oandreeva-nv oandreeva-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tm,lg

rmccorm4
rmccorm4 previously approved these changes Feb 16, 2024
@kthui kthui merged commit d6ab1ef into main Feb 17, 2024
3 checks passed
@kthui kthui deleted the jacky-res-stats branch February 17, 2024 01:38
yinggeh pushed a commit that referenced this pull request Feb 20, 2024
* Add response statistics

* Add L0_response_statistics

* Enable http vs grpc statistics comparison

* Add docs for response statistics protocol

* Add more comments for response statistics test

* Remove model name from config

* Improve docs wordings

* [Continue] Improve docs wordings

* [Continue] Add more comments for response statistics test

* [Continue 2] Improve docs wordings

* Fix typo

* Remove mentioning decoupled from docs

* [Continue 3] Improve docs wordings

* [Continue 4] Improve docs wordings

Co-authored-by: Ryan McCormick <[email protected]>

---------

Co-authored-by: Ryan McCormick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants