-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add response statistics #6869
Merged
Merged
Add response statistics #6869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 7, 2024
oandreeva-nv
reviewed
Feb 8, 2024
oandreeva-nv
reviewed
Feb 8, 2024
oandreeva-nv
reviewed
Feb 8, 2024
oandreeva-nv
reviewed
Feb 8, 2024
oandreeva-nv
reviewed
Feb 8, 2024
oandreeva-nv
reviewed
Feb 9, 2024
oandreeva-nv
reviewed
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides readme, this pr lgtm. In case of urgency ping me and I'll approve, we can follow up with clarifications to readme later.
oandreeva-nv
previously approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tm,lg
rmccorm4
reviewed
Feb 16, 2024
rmccorm4
reviewed
Feb 16, 2024
rmccorm4
reviewed
Feb 16, 2024
rmccorm4
reviewed
Feb 16, 2024
rmccorm4
reviewed
Feb 16, 2024
rmccorm4
reviewed
Feb 16, 2024
rmccorm4
previously approved these changes
Feb 16, 2024
Co-authored-by: Ryan McCormick <[email protected]>
rmccorm4
approved these changes
Feb 17, 2024
yinggeh
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Add response statistics * Add L0_response_statistics * Enable http vs grpc statistics comparison * Add docs for response statistics protocol * Add more comments for response statistics test * Remove model name from config * Improve docs wordings * [Continue] Improve docs wordings * [Continue] Add more comments for response statistics test * [Continue 2] Improve docs wordings * Fix typo * Remove mentioning decoupled from docs * [Continue 3] Improve docs wordings * [Continue 4] Improve docs wordings Co-authored-by: Ryan McCormick <[email protected]> --------- Co-authored-by: Ryan McCormick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Add tests for response statistics.