Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update OpenVINO model generation version #7811

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Nov 18, 2024

What does the PR do?

Triton uses OpenVINO version 2024 however our models still generated with version 2023.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build

Related PRs:

Where should the reviewer start?

Test plan:

L0_openvino_models--base
L0_model_config--base

  • CI Pipeline ID:
    20540633

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@yinggeh yinggeh added the PR: build Changes that affect the build system or external dependencies label Nov 18, 2024
@yinggeh yinggeh requested a review from mc-nv November 18, 2024 21:35
@yinggeh yinggeh self-assigned this Nov 18, 2024
@yinggeh yinggeh marked this pull request as draft November 18, 2024 21:40
@@ -2486,8 +2489,7 @@ def create_fixed_models(
import torch
from torch import nn
if FLAGS.openvino:
from openvino.inference_engine import IENetwork
import ngraph as ng
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nGraph API is deprecated and will be removed in the 2024.0 release. See opencv/opencv#24589

@yinggeh yinggeh marked this pull request as ready for review November 18, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: build Changes that affect the build system or external dependencies
Development

Successfully merging this pull request may close these issues.

1 participant