Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Default max tokens to None for OpenAI frontend. #7819

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thealmightygrant
Copy link

@thealmightygrant thealmightygrant commented Nov 20, 2024

What does the PR do?

As described in #7796, the default for max_tokens should be None rather than 16. This is consistent with both OpenAI's endpoints and vLLM. Please see the linked issue for more details.

Checklist

  • I have read the Contribution guidelines and signed the Contributor License
    Agreement
  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • I ran pre-commit locally (pre-commit install, pre-commit run --all)
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Test plan:

I will test on my local triton instance that is running this frontend.

Caveats:

I didn't go through and try to fix any tests that assume the existing default.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant