fix: Default max tokens to None for OpenAI frontend. #7819
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
As described in #7796, the default for
max_tokens
should be None rather than 16. This is consistent with both OpenAI's endpoints and vLLM. Please see the linked issue for more details.Checklist
Agreement
<commit_type>: <Title>
pre-commit install, pre-commit run --all
)Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Test plan:
I will test on my local triton instance that is running this frontend.
Caveats:
I didn't go through and try to fix any tests that assume the existing default.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)