Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: minor improvement on L0_infer infer_test.py skip pytorch test output msg #7971

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

ziqif-nv
Copy link
Contributor

What does the PR do?

minor improvement on L0_infer infer_test.py skip pytorch test output msg to make it clearer

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

  • CI Pipeline ID:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

@krishung5
Copy link
Contributor

Could you run the pre-commit hook for the formatting?

@ziqif-nv
Copy link
Contributor Author

Could you run the pre-commit hook for the formatting?

thanks. installed

Copy link
Contributor

@krishung5 krishung5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Please wait for the pipeline to complete before merging.

@ziqif-nv ziqif-nv merged commit 4f5c810 into main Jan 28, 2025
3 checks passed
@ziqif-nv ziqif-nv deleted the improve_infer_test_output_msg branch January 28, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants