Skip to content

fix: Proper handling of shape tensor size #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2025
Merged

fix: Proper handling of shape tensor size #110

merged 2 commits into from
May 7, 2025
+6 −1

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented May 3, 2025 •
edited
Loading

What does the PR do?

Add check to prevent integer underflow of shape tensor size.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • fix

Related PRs:

Where should the reviewer start?

Test plan:

  • CI Pipeline ID:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@yinggeh yinggeh added the enhancement New feature or request label May 3, 2025
@yinggeh yinggeh requested review from tanmayv25 and krishung5 May 3, 2025 01:51
@yinggeh yinggeh self-assigned this May 3, 2025
tanmayv25
tanmayv25 approved these changes May 3, 2025
View reviewed changes
Copy link
Contributor

@tanmayv25 tanmayv25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as it seems an innocuous check.

@yinggeh yinggeh changed the title fix: Proper handling of shape tensor size fix: Proper handling of shape tensor size May 7, 2025
@yinggeh yinggeh merged commit e4c91d4 into main May 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmayv25 tanmayv25 tanmayv25 approved these changes

@krishung5 krishung5 Awaiting requested review from krishung5

Assignees

@yinggeh yinggeh

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yinggeh @tanmayv25