Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added runtime/rust/ATTRIBUTIONS-Rust.md #115

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

dmitry-tokarev-nv
Copy link
Contributor

@dmitry-tokarev-nv dmitry-tokarev-nv commented Feb 5, 2025

What does the PR do?

Added Rust attributions. See: https://github.com/triton-inference-server/triton_distributed/blob/dtokarev/rust-libs-attributions/runtime/rust/ATTRIBUTIONS-Rust.md

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

  • CI Pipeline ID:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

nnshah1
nnshah1 previously approved these changes Feb 5, 2025
Copy link
Collaborator

@nnshah1 nnshah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the fast turnaround!

@alec-flowers
Copy link
Contributor

Since its a markdown, I think @whoisj program will want to add a header with the copyright to it. Can you add that in?

@dmitry-tokarev-nv
Copy link
Contributor Author

Since its a markdown, I think @whoisj program will want to add a header with the copyright to it. Can you add that in?

Done

Copy link
Collaborator

@whoisj whoisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've no idea if this meet's Legal's standards, but it LGTM.

@dmitry-tokarev-nv dmitry-tokarev-nv merged commit 1c7c6d9 into main Feb 5, 2025
5 checks passed
@dmitry-tokarev-nv dmitry-tokarev-nv deleted the dtokarev/rust-libs-attributions branch February 5, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants