-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add triton_distributed_rs wheel install to container build #135
Merged
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c269b01
Optimize unnecessary docker rebuilds from COPY commands, fix python b…
rmccorm4 c58ff1a
Add known marker for venv
rmccorm4 f81c240
Install triton_distributed_rs wheel in container without venv
rmccorm4 de33e4b
Merge branch 'main' into rmccormick/test_python_bindings
rmccorm4 abe31f8
Remove unnecessary change from pyproject.toml on pytest markers
rmccorm4 3e4796e
Merge branch 'rmccormick/test_python_bindings' of github.com:triton-i…
rmccorm4 2c0d4bf
Merge branch 'main' into rmccormick/test_python_bindings
rmccorm4 be9484b
Merge branch 'main' into rmccormick/test_python_bindings
rmccorm4 d30c417
Build/install everything in uv venv, remove manual maturin/patchelf i…
rmccorm4 9c06f56
Add TODO
rmccorm4 0e0c9f1
Merge branch 'rmccormick/test_python_bindings' of github.com:triton-i…
rmccorm4 652566f
Merge branch 'main' of github.com:triton-inference-server/triton_dist…
rmccorm4 44de108
Merge branch 'main' into rmccormick/test_python_bindings
rmccorm4 be5c381
Merge branch 'main' into rmccormick/test_python_bindings
rmccorm4 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
runtime/rust/python-wheel/python/tests/test_bindings_install.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
# SPDX-License-Identifier: Apache-2.0 | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import pytest | ||
|
||
pytestmark = pytest.mark.pre_merge | ||
|
||
|
||
def test_bindings_install(): | ||
# Verify python bindings to rust can be imported | ||
import triton_distributed_rs as tdr | ||
|
||
# Placeholder to avoid unused import errors or removal by linters | ||
assert tdr |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you do
maturin build
instead ofmaturin develop
, then virtual environment is not requiredThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did have that originally f81c240, but the issue with having everything installed in system environment (not the virtual environment) - is that there were unresolved issues with trying to
pip install vllm
for theexamples/python_rs/llm/vllm
example in the system environment. See #134.So for now, to keep both old pure python examples/tests working, and new mixed python/rust examples working - I went for this approach.
I'd prefer to move towards all or nothing in terms of virtualenv usage or not - but I think we'd need to figure out the issues with the vllm install to remove the virtualenv.
I decided to move forward with test/pipeline improvements before going back to debug the vllm install issue, because I figured we'd make a decision in the near future to install
vllm>=0.7
in the container at some point when doing./build.sh --framework vllm
anyways - but may need to avoid breaking the pure-python vllm disagg example (which patches vllm install) when doing so.